modern.js icon indicating copy to clipboard operation
modern.js copied to clipboard

fix: MApp can't pass props

Open zhoushaw opened this issue 3 years ago • 2 comments

PR Details

fix: MApp can't pass props

How Has This Been Tested

  • add e2e test

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project.
  • [x] I have updated changeset
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

zhoushaw avatar Jun 28 '22 07:06 zhoushaw

🦋 Changeset detected

Latest commit: aad1e55c2521cfd9e7870a3b957fb5bfcf8a0486

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@modern-js/plugin-garfish Patch
@cypress-test/garfish-dashboard Patch
@cypress-test/garfish-main Patch
@cypress-test/garfish-table Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 28 '22 07:06 changeset-bot[bot]

Codecov Report

Merging #1285 (aad1e55) into main (838a94e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files         834      834           
  Lines       36165    36165           
  Branches     6899     6899           
=======================================
  Hits        23393    23393           
  Misses      12741    12741           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 838a94e...aad1e55. Read the comment docs.

codecov[bot] avatar Jun 28 '22 07:06 codecov[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 11 committers have signed the CLA.

:white_check_mark: caohuilin
:white_check_mark: chenjiahan
:white_check_mark: yimingjfe
:white_check_mark: GiveMe-A-Name
:white_check_mark: zllkjc
:x: targeral
:x: 10Derozan
:x: KyrieLii
:x: zhoushaw
:x: nyqykk
:x: xuchaobei
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 22 '22 06:11 CLAassistant