webauthn-framework icon indicating copy to clipboard operation
webauthn-framework copied to clipboard

Refactor code for deprecation of "id" property

Open Spomky opened this issue 2 years ago • 1 comments

The "id" property in the PublicKeyCredential is deprecated. This commit refactors the relevant code, specifically in the "PublicKeyCredential" class and several test classes, to replace the use of "Base64UrlSafe::decode($publicKeyCredential->id)" with "$publicKeyCredential->rawId". The changes are made such that the functionality is maintained but future compatibility is ensured.

Target branch: 4.9.x Resolves issue #581

  • [x] It is a Bug fix
  • [ ] It is a New feature
  • [ ] Breaks BC
  • [ ] Includes Deprecations

Spomky avatar Apr 09 '24 09:04 Spomky

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 09 '24 09:04 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 15 '24 10:06 sonarqubecloud[bot]