ngx-image-gallery icon indicating copy to clipboard operation
ngx-image-gallery copied to clipboard

Angular 5+ support

Open MortezaT opened this issue 6 years ago • 10 comments

After install, it warns about @angular/core@^4.0.0 dependency.

[email protected] requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.

MortezaT avatar May 06 '18 13:05 MortezaT

I will updated in the next few days!

AnthonyNahas avatar May 07 '18 07:05 AnthonyNahas

Worth updating straight to angular 6 and rxjs 6.

HarelM avatar Jun 02 '18 10:06 HarelM

+1 angular 6 support

PabloPerezAguilo avatar Jun 16 '18 14:06 PabloPerezAguilo

Any updates on this? I would really love to get rid of those warnings...

HarelM avatar Jul 25 '18 19:07 HarelM

Angular 7 has just come out, this would be a good time to update this package...

HarelM avatar Oct 29 '18 19:10 HarelM

Anyone else trying to run in Angular 7 and seeing compilation issues in AOT? I submitted a PR (#41), but I haven't been able to verify the fix as I have yet to build this from source but I'd be shocked if others weren't going to run into this problem also.

Environment

  • Angular 7.1.4
  • TypeScript 3.1.6
  • Node 10.x LTS

DanielCaspers avatar Dec 31 '18 00:12 DanielCaspers

I'm using skipLibCheck in my tsconfig file so I'm able to use angular 7 with aot.

HarelM avatar Dec 31 '18 08:12 HarelM

@HarelM thanks for the idea. That exact suggestion didn't work for me. Instead, the fix for me was

"angularCompilerOptions": { "fullTemplateTypeCheck": false }

It might matter that this code was in an Angular library for me; not sure though...

DanielCaspers avatar Dec 31 '18 15:12 DanielCaspers

@maintainers any updates on this? I'm still getting warnings when using npm install...

HarelM avatar Feb 21 '19 20:02 HarelM

@thatisuday I saw your last commit about looking for someone to help maintain this package. I'll be happy to help out, please let me know how I can help. I would love to start with this issue which is open for more than a year now.

HarelM avatar Jun 26 '19 16:06 HarelM