weaviate icon indicating copy to clipboard operation
weaviate copied to clipboard

Duplicate CONTEXTIONARY_URL in dev setup

Open aminst opened this issue 1 year ago • 1 comments

I was trying to run weaviate-server locally using the run_dev_server.sh file. I noticed there are unnecessary CONTEXTIONARY_URLs passed as environment variables. There are multiple ones with the same issue in the run_dev_server file. For example:

 second-node)
      GRPC_PORT=50052 \
      CONTEXTIONARY_URL=localhost:9999 #HERE \
      AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED=true \
      PERSISTENCE_DATA_PATH="./data-weaviate-1" \
      BACKUP_FILESYSTEM_PATH="${PWD}/backups-weaviate-1" \
      CLUSTER_HOSTNAME="weaviate-1" \
      CLUSTER_IN_LOCALHOST=true \
      CLUSTER_GOSSIP_BIND_PORT="7102" \
      CLUSTER_DATA_BIND_PORT="7103" \
      CLUSTER_JOIN="localhost:7100" \
      RAFT_PORT="8302" \
      RAFT_INTERNAL_RPC_PORT="8303" \
      RAFT_JOIN="weaviate-0:8300,weaviate-1:8302,weaviate-2:8304" \
      RAFT_BOOTSTRAP_EXPECT=3 \
      CONTEXTIONARY_URL=localhost:9999 # HERE \
      DEFAULT_VECTORIZER_MODULE=text2vec-contextionary \
      ENABLE_MODULES="text2vec-contextionary,backup-filesystem" \
      go_run ./cmd/weaviate-server \
        --scheme http \
        --host "127.0.0.1" \
        --port 8081 \
        --read-timeout=600s \
        --write-timeout=600s
    ;;

Is this intentional? I can fix it if this was not intended.

aminst avatar Apr 25 '24 13:04 aminst

@aminst this is not intentional. Please feel free to raise a PR.

trengrj avatar Apr 30 '24 10:04 trengrj