weaviate icon indicating copy to clipboard operation
weaviate copied to clipboard

Add endpoint for checking if tenant exists

Open litlig opened this issue 1 year ago • 6 comments

What's being changed:

https://github.com/weaviate/weaviate/issues/3472

Review checklist

  • [ ] Documentation has been updated, if necessary. Link to changed documentation:
  • [ ] Chaos pipeline run or not necessary. Link to pipeline:
  • [ ] All new code is covered by tests where it is reasonable.
  • [ ] Performance tests have been run or not necessary.

litlig avatar Feb 07 '24 04:02 litlig

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Feb 08 '24 02:02 weaviate-git-bot

I agree with the CLA

litlig avatar Feb 08 '24 05:02 litlig

Hi @litlig, thanks for the PR for this feature! The CI fails because you need to run the auto-generation code to generate the Go structs from the OpenAPI swagger config, cheers!

tsmith023 avatar Feb 12 '24 10:02 tsmith023

hey @tsmith023, thanks for taking a look! I did run the gen-code-from-swagger.sh to autogen swagger code. The CI error seems to be complaining about deprecations/data.go, which got formatted by swagger gen. I reverted change to that file.

litlig avatar Feb 12 '24 23:02 litlig

Hi @litlig, thanks for tidying up this PR and getting it into such a good shape! I will give it a review in the coming days when I get the chance 😁

tsmith023 avatar Feb 14 '24 09:02 tsmith023

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 20 '24 21:02 sonarqubecloud[bot]

Thanks for the contribution! Can you please add some tests? Probably just an acceptance (end2end) test would suffice. Check the existing multi-tenancy tests for reference

Thanks for the pointer! Tests added.

litlig avatar Feb 20 '24 21:02 litlig

Very nice @litlig everything looks in order. Will have this merged in shortly

parkerduckworth avatar Feb 21 '24 15:02 parkerduckworth