weaviate-python-client icon indicating copy to clipboard operation
weaviate-python-client copied to clipboard

typo (?) in embedded.py unable to open binary file diagnostic message incorrect/unhelpful

Open OldishCoder opened this issue 1 year ago • 0 comments

    if not self._weaviate_binary_path.exists():
            print(
                f"Binary {self.options.binary_path} did not exist. Downloading binary from {self._download_url}"
            )

From context and my own debugging issues in WSL2/Ubuntu - I think line 140 should read:

    if not self._weaviate_binary_path.exists():
            print(
                f"Binary {self._weaviate_binary_path} did not exist. Downloading binary from {self._download_url}"
            )

https://github.com/weaviate/weaviate-python-client/blob/10b6a5bc6a4391e1831df36110e6ecafcf2d8bc1/weaviate/embedded.py#L140

OldishCoder avatar Mar 08 '24 18:03 OldishCoder