weaviate-helm icon indicating copy to clipboard operation
weaviate-helm copied to clipboard

Add templating for env variables using valueFrom.

Open nethi opened this issue 1 year ago • 1 comments

This is useful for scenarios like dealing with issue of "Failed to get final advertise address: No private IP address found, and explicit IP not provided". Weaviate troubleshooting documents to fix it using CIDR change, but this mayn't be feasible always.

As mentioned in this issue, the workaround of using CLUSTER_ADVERTISE_ADDR actually works. But we cannot use with this helm chart because values.yaml doesn't allow configuring it. This PR tries to fix it. There may be other use cases where this ability could help also

env:
  - name: CLUSTER_ADVERTISE_ADDR
    valueFrom:
      fieldRef:
        apiVersion: v1
        fieldPath: status.podIP

nethi avatar Oct 08 '24 12:10 nethi

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Oct 09 '24 10:10 weaviate-git-bot