weaveworks
Create config file on CLI action with user prompt for analytics
Closes #2843
all commands now attempt to read the config file before running, and create a config file if it doesn't exist - with a user prompt for analytics!
❔ Will the following acceptance criteria be implemented solely in the enterprise repo?
On Enterprise, this shouldn't ask - it should just turn it on if it's the first run.
The PR description says it closes the ticket completely (same issue as with my config commands PR).
❔ Will the following acceptance criteria be implemented solely in the enterprise repo?
"On Enterprise, this shouldn't ask - it should just turn it on if it's the first run."
The PR description says it closes the ticket completely (same issue as with my config commands PR).
Yep - going to open a follow-up PR in enterprise after yours is merged!
@JamWils or @josefaworks: the ticket for this talked about linking to our documentation - I think that's this page, but it needs updating for pendo, and I'm not sure if it requires any legalese given that this is now a 3rd party: https://docs.gitops.weave.works/docs/feedback-and-telemetry/
Should we hold off on merging this until the documentation is there?
@ozamosi @joshri yes, turns out it's the same URL (with updates): https://docs.gitops.weave.works/docs/feedback-and-telemetry/
Added the link to the ticket description too.
Picking up this PR, because we need to merge it before other Pendo PRs I suppose. Will just add the link to the docs and will create an enterprise counterpart for it.
@ozamosi
- Refactored the analytics config initialization by explicitly setting default values.
- Added text with a link to the feedback and telemetry documentation page before the prompt. Updated the pre-link text and prompt based on @ozamosi 's suggestion.
- Reworked config imports for consistency within this PR and with the Pendo CLI events PR (and to make all config package aliases lowercase).