weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Source URL hyperlink should respect reference

Open sympatheticmoose opened this issue 3 years ago • 4 comments

For users trying to navigate to their defined source, it would make things a lot simpler if they could follow the hyperlink and that take them to the correct fetched reference - a branch, tag or semver-tag.

The URL display text could match spec.url i.e. https://github.com/stefanprodan/podinfo

The hyperlink should be informed by the status.revision of the deployed source. Crucial for the semver example.

ref.commit=<example> or ref.branch=<example> = https://github.com/stefanprodan/podinfo/tree/<example>

ref.tag=<example> or ref.semver=<example> = https://github.com/stefanprodan/podinfo/tag/<example>

sympatheticmoose avatar Aug 04 '22 14:08 sympatheticmoose

Somewhat relevant issue for consideration https://github.com/weaveworks/weave-gitops/issues/2115

sympatheticmoose avatar Aug 05 '22 10:08 sympatheticmoose

Which git forges are in scope for this ticket?

ozamosi avatar Aug 05 '22 10:08 ozamosi

fair point, I see how that would increase complexity and in which case @JamWils would need to weigh in on priority order. My suggestion would be github.com > gitlab.com ~> gitlab on prem > ghe~. Others unsupported for now.

sympatheticmoose avatar Aug 05 '22 11:08 sympatheticmoose

🤔 I definitely agree on GitHub and GitLab. Also it would be nice to be taken to the correct ref. I think we just need to be clear about the level of scope before this gets picked up.

JamWils avatar Aug 08 '22 19:08 JamWils

This has been open a long time now. I'm going to close this for the moment as it could be some time until we get to it.

JamWils avatar Feb 28 '23 22:02 JamWils