Refined table style with standardised spacing

cc @TheGostKasper
Acceptance Criteria
- [ ] Column title text is
semi-bold12pxProxima Nova with the sorting column title in 'Neutral 40' (#1a1a1a) and all other column titles in 'Neutral 30' (#737373) - [ ] height of title row should be
32pxwith#F6F7F9background - [ ] height of content row should be
40pxwith white background - [ ] sub-tables are indented by
24px - [ ] closed sub-tables have a right-facing chevron icon
- [ ] expanded sub-tables have a downward-facing chevron icon
- [ ] page elements should be separated by
16px,24px, or48pxas described above - [ ]
theme.tsreflects these semantic choices in
// 16px
base: `${baseSpacingNumber}px`,
// 32px
large: `${baseSpacingNumber * 2}px`,
// 24px
medium: `${baseSpacingNumber * 1.5}px`,
none: "0",
// 12px
small: `${baseSpacingNumber * 0.75}px`,
// 48px
xl: `${baseSpacingNumber * 3}px`,
// 8px
xs: `${baseSpacingNumber * 0.5}px`,
// 64px
xxl: `${baseSpacingNumber * 4}px`,
// 4px
xxs: `${baseSpacingNumber * 0.25}px`,
},
References
@bia The link to Figma is broken for me, here is what I see:
Could you please check the link to Figma and make the document viewable by all members of @weaveworks/denim ?
We need it to be able to review a related PR.
hi @opudrovs , it seems that you did not have access to the Figma design system. Who else needs access besides @TheGostKasper ?
Hi @bia thanks, me, @joshri , @ozamosi , @chanwit and @katya-makarevich need the access, please.
-
closed sub-tables have a right-facing chevron icon
-
expanded sub-tables have a downward-facing chevron icon We don't have sub-tables in oss - was this meant for enterprise?
-
page elements should be separated by 16px, 24px, or 48px as described above Many of the page elements of the design don't exist in oss which could influence the numbers here.
-
theme.ts reflects these semantic choices in The theme already has these numbers in oss so we should be good here.
expanded sub-tables have a downward-facing chevron icon We don't have sub-tables in oss - was this meant for enterprise?
Sub-tables are something that we have been further refining this week for Enterprise. @joshri should I follow up on the final design here, or should I create a separate issue for it?
I have now updated this issue with our latest sub-table design