weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Refined table style with standardised spacing

Open bia opened this issue 3 years ago • 6 comments

Table filtered selectable Table filtered selectable 2 Table with Sub-table Open

cc @TheGostKasper

Acceptance Criteria

  • [ ] Column title text is semi-bold 12px Proxima Nova with the sorting column title in 'Neutral 40' (#1a1a1a) and all other column titles in 'Neutral 30' (#737373)
  • [ ] height of title row should be 32px with #F6F7F9 background
  • [ ] height of content row should be 40px with white background
  • [ ] sub-tables are indented by 24px
  • [ ] closed sub-tables have a right-facing chevron icon
  • [ ] expanded sub-tables have a downward-facing chevron icon
  • [ ] page elements should be separated by 16px, 24px, or 48px as described above
  • [ ] theme.ts reflects these semantic choices in
    // 16px
    base: `${baseSpacingNumber}px`,
    // 32px
    large: `${baseSpacingNumber * 2}px`,
    // 24px
    medium: `${baseSpacingNumber * 1.5}px`,
    none: "0",
    // 12px
    small: `${baseSpacingNumber * 0.75}px`,
    // 48px
    xl: `${baseSpacingNumber * 3}px`,
    // 8px
    xs: `${baseSpacingNumber * 0.5}px`,
    // 64px
    xxl: `${baseSpacingNumber * 4}px`,
    // 4px
    xxs: `${baseSpacingNumber * 0.25}px`,
  },

References

Figma

bia avatar Jul 22 '22 13:07 bia

@bia The link to Figma is broken for me, here is what I see:

Screenshot 2022-08-09 at 16 25 16

Could you please check the link to Figma and make the document viewable by all members of @weaveworks/denim ?

We need it to be able to review a related PR.

opudrovs avatar Aug 09 '22 14:08 opudrovs

hi @opudrovs , it seems that you did not have access to the Figma design system. Who else needs access besides @TheGostKasper ?

bia avatar Aug 09 '22 14:08 bia

Hi @bia thanks, me, @joshri , @ozamosi , @chanwit and @katya-makarevich need the access, please.

opudrovs avatar Aug 09 '22 14:08 opudrovs

  • closed sub-tables have a right-facing chevron icon

  • expanded sub-tables have a downward-facing chevron icon We don't have sub-tables in oss - was this meant for enterprise?

  • page elements should be separated by 16px, 24px, or 48px as described above Many of the page elements of the design don't exist in oss which could influence the numbers here.

  • theme.ts reflects these semantic choices in The theme already has these numbers in oss so we should be good here.

joshri avatar Sep 01 '22 12:09 joshri

expanded sub-tables have a downward-facing chevron icon We don't have sub-tables in oss - was this meant for enterprise?

Sub-tables are something that we have been further refining this week for Enterprise. @joshri should I follow up on the final design here, or should I create a separate issue for it?

bia avatar Sep 01 '22 15:09 bia

I have now updated this issue with our latest sub-table design

bia avatar Sep 06 '22 15:09 bia