weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Export all the (UI) things

Open jpellizzari opened this issue 3 years ago • 5 comments

We currently maintain an index.ts file that describes all the things that the weave-gitops NPM module exports. Instead of maintaining this, we should just export everything. We already consume go packages from -core without any manual exports defined, so this will align with that.

Some historical context: we had originally intended to export only the ENTIRE core app and have it called into the EE app; instead the EE team decided to import individual components (this made routing, etc easier).

jpellizzari avatar Jun 14 '22 16:06 jpellizzari

Gave up on this for now. I tried getting rid of individual exports, but gave up due to not having very good control of the build system in EE. It is still "unejected" create-react-app, and is giving error messages that don't leave breadcrumbs.

Here is the work I did: https://github.com/weaveworks/weave-gitops/tree/2321-js-exports

Selfishly, I also didn't want to sign on to update all the exports in the EE repo (at least right now)

Module is here: https://github.com/weaveworks/weave-gitops/packages/945027

jpellizzari avatar Jun 15 '22 17:06 jpellizzari

@jpellizzari is this still valid?

sympatheticmoose avatar Nov 04 '22 13:11 sympatheticmoose

Yes still valid and useful

jpellizzari avatar Nov 04 '22 17:11 jpellizzari

@jpellizzari Same question as before, but 10 months later :)

lasomethingsomething avatar Sep 01 '23 07:09 lasomethingsomething

@jpellizzari Same question as before, but 10 months later :)

Same answer unfortunately :cry:

But progress is being made!

jpellizzari avatar Sep 01 '23 17:09 jpellizzari