weave-gitops
weave-gitops copied to clipboard
Potential race flake in core/server/sync_test.go
Describe the bug
CI failed on core/server/sync_test.go in TestSync
panic: send on closed channel
goroutine 11395 [running]:
github.com/weaveworks/weave-gitops/core/server_test.TestSync.func1.1()
/home/runner/work/weave-gitops/weave-gitops/core/server/sync_test.go:105 +0x6b
created by github.com/weaveworks/weave-gitops/core/server_test.TestSync.func1
/home/runner/work/weave-gitops/weave-gitops/core/server/sync_test.go:103 +0x245
Is this a UI bug or a server bug?
- [ ] UI
- [ ] Server
- [x] Test!
What is the severity of the bug
- [ ]
severity/Critical: Weave GitOps is crashing, the UI is inaccessible or a key feature is unusable. There is no known workaround. - [ ]
severity/Major: Weave Gitops functionality or a key feature is broken. There is a workaround, but the workaround requires significant effort. - [ ]
severity/Minor: A non-key feature or functionality is broken. There is a fairly straightforward workaround. - [x]
severity/Low: Doesn’t affect primary flow/functionality but would be good to fix.
Environment
make unit-tests at d74794b8
To Reproduce
Steps to reproduce the behavior:
go test -run 'TestSync$' ./core/server
Expected behavior Should pass and not fail.
Additional context This is a very rare flake so there is zero need to rush and fix this unless a) it comes back again and frequently, or b) you are very bored.