weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Move the Enterprise CLI commands into a different repo

Open Callisto13 opened this issue 2 years ago • 3 comments

We want to simplify the OSS codebase and the CLI as a product in general. The first step is to move the enterprise CLI commands into a separate repository and import them into the OSS CLI. This will be temporary and eventually the enterprise CLI commands will be easily installable as a plugin to the OSS CLI.

Acceptance Criteria

  1. The code for the enterprise CLI commands are no longer in the weave-gitops repo and are imported and added to cobra.
  2. All CLI commands that are Enterprise specific still exist in the product.

Historical reference

Arguments for:

  • So much of the CLI pieces are enterprise related. It is always jarring to find CAPI, cluster, etc things in Core.
  • WeGo core is now pretty much a UI for Flux. Even if we start to have some more Core CLI functionality, it is really a separate concern from the rest of the repo.
  • The releases on this repo are currently tied to binaries, not Helm Charts which is just... so weird, since it is the version of the API, Server and the Chart which matters in this place.
  • Architecturally and product-wise it makes more sense.

Arguments against:

  • Release processes would need to be moved
  • Alterations in both EE and Core
  • You like to make Claudia sad I guess

Callisto13 avatar Apr 22 '22 14:04 Callisto13

Ideally we would end up with 4+ repos:

  • Core
  • EE
  • CLI
  • (mad)libs
  • (profiles controller/helm watcher thingy)

But... baby steps i guess

Callisto13 avatar Apr 22 '22 14:04 Callisto13

Yes, I want to come up with a plan to do this sooner rather than later. Having the two so intertwined just doesn't make sense per the Notion doc (The Three Project Conundrum) I wrote up.

JamWils avatar Apr 25 '22 20:04 JamWils

It sounds like @ozamosi is already pulling together a POC for this.

JamWils avatar Apr 26 '22 18:04 JamWils