weave-gitops-enterprise
weave-gitops-enterprise copied to clipboard
weaveworks
[UI/BE] Add Delete buttons for resources that can be edited
https://github.com/weaveworks/weave-gitops-interlock/issues/362
- We show an edit button for anything that has the "create-request" annotation.
- Lets add a delete button too
BE
- Check that the deletion logic in the BE is using the list of files we generate and save in that annotation (or it might be a similarly named annotation)
@mmoulian ! We'll need to add a delete button where we have "edit" (✎ pencil icon) on the details pages for:
- clusters
- apps
- sources
Design options:
- add another delete button
- add a dropdown-button where delete is hiding (action dropdown menu)
wdyt?
@foot This is partly under discussion (at least as relates to the Application View) in the Pipelines UI work--see: https://miro.com/app/board/uXjVMFiEhxc=/?moveToWidget=3458764562516132531&cot=14. Missing Deletion has also come up in Pipelines--ie some way to shut down pipelines you no longer need.
One of the outcomes of the recent design/prod/FE sessions was that I'll be working with Design on tightening UI consistency. So let's align on this to work toward common experiences across views. :)
Yes, indeed.
Today the Edit button (that we're talking about expanding to include a Delete button), only covers resources that have been generated via a template. So perhaps we can call that out more explicitly in the UI somehow. Especially if we might have other concepts of deleting (if pipelines might move away from templates (?))
Hey @foot @LappleApple ! I made these options to introduce actions in the rows. The first is inspired by Google email. I really like it because the buttons only appear on hover. The second is a dropdown menu. wdyt?
https://github.com/weaveworks/weave-gitops-enterprise/assets/95616291/2067e55c-8451-46b1-9f98-b40044b89bb9
https://github.com/weaveworks/weave-gitops-enterprise/assets/95616291/07ef1ebd-cfb7-4a3a-8b93-8946882203db
I like the three dots better/Option 2 just because it will trigger the user to check out what's going on there. Option 1 feels a bit too hidden for me. @MostafaMegahid and @bigkevmcd, wdyt?
