Workload section items overlapping on VScode

[ruslanguns]

trafficstars

Expected behaviour

Expand and collapse should work smoothly.

Actual behaviour

Not sure if this is a problem with the current version of vscode or what, but I am getting this issue with the windows.

Not sure if that helps:

Steps to reproduce

• Open GitOps
• Expand items on Workloads

Versions

kubectl version: Flux version: v1.29.0 Git version: 2.34.1 Azure version: - Extension version: 0.26.0 VSCode version: 1.85.1 Operating System (OS) and its version: Windows 11 23H2

[devantler]

I can verify that this is also happening for me on MacOS (latest):

Furthermore, most of the menus are unstable. I have to reload VSCode everytime I want to check the status of a reconciliation successfully. Otherwise any menu item is unresponsive.

[joaocc]

I have a similar situation to @devantler (i'm also on macOS). I thought this was due to upgrading cli to 2.2.2 and flux on servers being 2.0.x, but even after upgrading all to latest version, this still happens.

[joaocc]

Hi. Is anyone working on this? As it stands, the plugin is pretty much unusable, both due the display issue mentioned above, but also because of lack of responsiveness for most other actions.

[Mariscal6]

I am having the same problem. The extension is currently not usable

[overtfuture]

Same thing for me as well. Upgraded to the latest and nothing is coming in.

[kingdonb]

I am so sorry for your experience. We released under pressure and I frankly have not seen these issues at all. I'm surprised at especially the UI overlapping issues because I've never seen a problem like that before.

If you select a version from the UI, can you tell whether this misbehavior was introduced by any specific version of the extension? If it was an error in an upgraded version, then I would expect you could pin to an earlier version and get the old behavior.

I do not see any similar issue on my installed copy that was upgraded to 0.26.0:

If you want to try install another version perhaps this can help us diagnose which version introduced the issue:

I haven't made any major changes to my VSCode since installing devcontainer. That broke basically every extension for me, so I had to reinstall my entire system. Now I get this security prompt each time, which of course I always trust everything 😅

[kingdonb]

I managed to get the editor locked after a few minutes of fumbling around, with this notification:

Not sure if it's related.

[overtfuture]

For my VSCode, I do not have workspace trust enabled at all. I went through the versions and it appears 0.25.0 stops working on my setup. I cannot reconcile or view any resources. After downgrading further to 0.24.3, it appears to be working again. Hope the versions help finding the bug and if not, send over any further tests. Thanks for checking in on this.

[juozasg]

Thank you everyone for the reports! The maintainers (me and @kingdonb) have been working on other projects since the holiday season. I tried the extension and I'm seeing the same issue! Treeviews that were tested working during our last release on December 6th are broken now. This appears to be caused by vscode version 1.85 that was released on the same day. I tried 1.84.2 version and there treeviews, the "openResource" double-click command, and the right-click context menus all work correctly.

Very possibly code changes related to the item "Sticky Scroll in tree views and the terminal" also broke our treeviews https://code.visualstudio.com/updates/v1_85

We're hoping to resolve it quickly! For now either please revert to vscode 1.84.2: https://code.visualstudio.com/updates/v1_84

OR revert to earlier (pre 0.25) version of the extension that uses simpler treeviews without live view of cluster resources.

[juozasg]

I implemented data and tree node caching to allow faster updates of the treeviews. I developed it by experimenting with TreeView behavior (refreshing, redrawing, collapsing/expand, changing labels and tree functions) and seeing how to use it to provide more responsive and less laggy UI. TreeView behaviors are not fully documented so i had to push the API maybe beyond what it was intended to do. To fix this, I'm trying to figure out how the TreeView model or rendering has changed in vscode 1.85.0. I couldn't find new issues or documentation changes about treeviews, except for the addition of Sticky Scroll. Visually, Sticky Scroll looks related to our treeviews bugging out.

Maybe possible to fix it and have better treeview code. First trying to reproduce the behavior with minimal code example. I will also submit a ticket with vscode to either document or fix the TreeView behavior changes in 1.85

Could also try to replace cluster resources treeviews with one Webview.

[kingdonb]

Tracking this in #503 now. We'll roll back to pre live-update behavior first, so new users don't get the bad experience.

More details in that issue. We may need to keep this issue open after we've triaged it, and until we can re-release the live update behavior in a way that doesn't break on the latest VSCode release.

Sorry for the long delay in getting this fixed, but we've been going through some things I can't talk about and I'm honestly not really even sure if I can still release this extension myself right now, until I throw the lever and it works!

Thanks for bearing with us, all community. ❤️