ui-components icon indicating copy to clipboard operation
ui-components copied to clipboard

Standardising line heights throughout components to match spacing

Open bia opened this issue 6 years ago • 1 comments

Builds upon #424, line heights of fonts are sporadically set in some but not most components which have text.

cc @miklosp

After quite some research, it seems best to implement a line height relative to font size of 1.618 throughout the entire app instead. @fbarl what is the best way to override this everywhere?

bia avatar Dec 06 '18 11:12 bia

Sounds good to me!

According to the article, it should be enough to add that one line of CSS somewhere at the top of our app (probably in service-ui rather than here) and then make sure we remove all the rest of line-heights from the styles. We could probably even add line-height to the stylelint blacklist to forbid the overrides: https://stylelint.io/user-guide/rules/property-blacklist/

fbarl avatar Jan 14 '19 10:01 fbarl