ui-components icon indicating copy to clipboard operation
ui-components copied to clipboard

TabSelect sometimes breaks when only one tab is passed

Open fbarl opened this issue 6 years ago • 2 comments

Probably due to the this.props.children structure when a singleton is passed down (probably not in the form of array).

Encountered when trying it on https://github.com/weaveworks/service-ui/pull/2647.

cc @jpellizzari

fbarl avatar Jun 04 '18 12:06 fbarl

@fbarl What is the symptom of the breaking?

jpellizzari avatar Jun 04 '18 16:06 jpellizzari

So for a single child in the example:

<TabSelect>
  <Tab label="A" name="a">
    Tab A
  </Tab>
</TabSelect>

the whole page crashes with

image

fbarl avatar Jun 06 '18 09:06 fbarl