scope icon indicating copy to clipboard operation
scope copied to clipboard

Mark private IPs as something other than "The Internet"

Open bboreham opened this issue 4 years ago • 5 comments

I saw a "The Internet" cloud icon in the Scope view, in a place where my software shouldn't be connecting to the internet.

Looking closer, the address was 172.217.9.202, which is in the RFC1918 private IP space so couldn't be on the Internet - it's something local to my cloud provider.

We could have a different caption for such addresses. "Private IP" ?

bboreham avatar Sep 23 '19 11:09 bboreham

"Private IP" label sounds good to me!

@bboreham are there any other IP ranges that come to your mind that should be named differently? Maybe we could also tackle those in this issue.

fbarl avatar Sep 27 '19 13:09 fbarl

I will work on this

praveensastry avatar Sep 30 '19 05:09 praveensastry

I will work on this

Please go ahead @praveensastry and let us know if you need any help!

fbarl avatar Sep 30 '19 10:09 fbarl

I'd also find this super useful - but for me the IP ranges are in the 10/8 range. These are still in the RFC1918 private IP space - so if you can make sure you get all three ranges (10/8, 172.16/12 and 192.168/16) that would be great.

argibbs avatar Oct 07 '19 10:10 argibbs

There's a nice Go prototype here how to check for private IP spaces: https://stackoverflow.com/questions/41240761/go-check-if-ip-address-is-in-private-network-space

fbarl avatar Oct 07 '19 10:10 fbarl