prom-aggregation-gateway icon indicating copy to clipboard operation
prom-aggregation-gateway copied to clipboard

[FEAT] Adding TTL to cleanup old metrics

Open nicolastakashi opened this issue 2 years ago • 2 comments

I'm taking over this PR https://github.com/weaveworks/prom-aggregation-gateway/pull/45

nicolastakashi avatar Jul 29 '22 22:07 nicolastakashi

Hi @nicolastakashi Raised a required fix into your fork, since current code doesn't add timestamp for new metrics, and they'll always get deleted when metrics are queried, unless they got updated before that: https://github.com/nicolastakashi/prom-aggregation-gateway/pull/1

shlompy avatar Sep 01 '22 12:09 shlompy

Hey @shlompy thanks for helping me and sorry for the late reply, I was on holiday. regarding the change LGTM

nicolastakashi avatar Sep 24 '22 12:09 nicolastakashi