mesh icon indicating copy to clipboard operation
mesh copied to clipboard

Change concrete *log.Logger to mesh.Logger interface

Open peterbourgon opened this issue 9 years ago • 2 comments
trafficstars

Proposed interface

type Logger interface {
    Logf(format string, args ...interface{})
}

peterbourgon avatar Apr 04 '16 14:04 peterbourgon

Compare https://github.com/Sirupsen/logrus/blob/master/logrus.go#L97

(not claiming I can see an easy middle ground)

See also https://github.com/weaveworks/weave/commit/c38dcb1d73349eaf5336d6541552e1edb15ff7db

bboreham avatar Apr 04 '16 15:04 bboreham

Yeah, there's a lot to consider. I'm definitely against an interface with more than 1 method, see this presentation from a Go kit collaborator for a good recap of my journey with logging. And sorry to make you use that logLogger.

peterbourgon avatar Apr 04 '16 15:04 peterbourgon