common
common copied to clipboard
weaveworks
instrument.CollectedRequest believes everything is an RPC
I.e. this line:
ext.SpanKindRPCClient.Set(sp)
is unwarranted. Maybe it should be parameterised?
Why is this a problem? Is it that the function is doing unnecessary extra work?
On Wed, 21 Feb 2018 at 13:47 Bryan Boreham [email protected] wrote:
I.e. this line:
ext.SpanKindRPCClient.Set(sp)
is unwarranted. Maybe it should be parameterised?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weaveworks/common/issues/88, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHq6mYPHV3SOQC1cXHHCXsh9oRZXO9xks5tXB5ngaJpZM4SNqRp .
It means my tracing infrastructure is carrying extra data that is meaningless.
It means I cannot use the span.kind tag to filter RPC client operations.
Also I have a vague idea that Jaeger tries to match up client and server sides of the same operation, which this would pollute.