common icon indicating copy to clipboard operation
common copied to clipboard

Published 20 hours ago • verified publisher icon weaveworks

httpgrpc/server: Update NewClient to not use WithBalancerName

Open metalmatze opened this issue 3 years ago • 4 comments

Additionally, gRPC was bumped to v1.34.0 to support the insecure.NewCredentials()

Closes #239

cc @bboreham

metalmatze avatar May 03 '22 10:05 metalmatze

@metalmatze any updates when this PR could be merged?

mar4uk avatar May 16 '22 11:05 mar4uk

This week I'm at KubeCon and then need to see. If others could check in the meantime I'm happy getting it merged without me.

metalmatze avatar May 16 '22 11:05 metalmatze

For clarity, I am looking for someone to say "we tested forwards/backwards compatibility by doing xxx, and it was fine".

bboreham avatar May 16 '22 15:05 bboreham

Ping, in case any of you have updates on testing gRPC compatibility.

bboreham avatar Jul 06 '22 10:07 bboreham

Sorry, currently don't have the time to work on this. If someone does feel free to pick it up again.

metalmatze avatar Aug 18 '22 09:08 metalmatze

Hopefully https://github.com/weaveworks/common/pull/254 gets us there. Thanks @jpkrohling

metalmatze avatar Aug 31 '22 13:08 metalmatze