common icon indicating copy to clipboard operation
common copied to clipboard

Uses unlicensed opentracing-contrib/go-grpc

Open asuffield opened this issue 6 years ago • 2 comments

server/server.go imports github.com/opentracing-contrib/go-grpc

This repo doesn't have a license (https://github.com/opentracing-contrib/go-grpc/issues/3), so this makes weaveworks/common unusable for us.

go-grpc looks trivial, so if getting it licensed is somehow hard, it would probably not take very long to rewrite...

asuffield avatar Jul 04 '19 10:07 asuffield

Thanks for raising this. The code in that package was from https://github.com/grpc-ecosystem/grpc-opentracing, which does display a licence. I think we can assume this is an oversight in copying files rather than a real lack of licence.

I'll try again to make contact with its maintainers.

bboreham avatar Feb 19 '20 10:02 bboreham

The upstream issue is now fixed. Can we update our dep?

dholbach avatar Aug 13 '20 12:08 dholbach