common icon indicating copy to clipboard operation
common copied to clipboard

Can't pass in options to opentracing handler

Open gouthamve opened this issue 7 years ago • 1 comments

So, the query endpoint AND the /metrics endpoint both end up under the operation: "HTTP GET" and this clutters up a traces a fair bit.

We could pass in something like this: https://godoc.org/github.com/opentracing-contrib/go-stdlib/nethttp#OperationNameFunc to differentiate both but because opentracing is a default middleware, there is no way to do that, see: https://github.com/weaveworks/common/blob/master/middleware/http_tracing.go#L17

Now, we can pass in the options to the tracer, but would you open to adding something like OpentracingOptions to server.Config?

gouthamve avatar Sep 14 '18 06:09 gouthamve

The specific problem described was addressed at #126. Do you still need options?

bboreham avatar Feb 19 '20 10:02 bboreham