flintlock icon indicating copy to clipboard operation
flintlock copied to clipboard

adding provider to convert

Open steve-fraser opened this issue 1 year ago • 6 comments

What this PR does / why we need it:

Added missing provider to convert method

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

  • [ ] squashed commits into logical changes
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

steve-fraser avatar Jan 08 '24 17:01 steve-fraser

Thanks @steve-fraser could you fix the tests and push again?

Callisto13 avatar Jan 08 '24 17:01 Callisto13

@Callisto13 do you need to approve it to run the test?

steve-fraser avatar Jan 08 '24 17:01 steve-fraser

@steve-fraser are you running the build or tests locally before you push?

Callisto13 avatar Jan 08 '24 17:01 Callisto13

@Callisto13 I wasn't before, but I did now and everything seems to be passing after a few commits :)

steve-fraser avatar Jan 08 '24 18:01 steve-fraser

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c467027) 58.18% compared to head (8007c58) 58.21%.

:exclamation: Current head 8007c58 differs from pull request most recent head 03d3230. Consider uploading reports for the commit 03d3230 to get more accurate results

Files Patch % Lines
infrastructure/grpc/convert.go 0.00% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   58.18%   58.21%   +0.03%     
==========================================
  Files          56       56              
  Lines        2705     2707       +2     
==========================================
+ Hits         1574     1576       +2     
  Misses        985      985              
  Partials      146      146              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 08 '24 18:01 codecov-commenter

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Feb 08 '24 07:02 github-actions[bot]