kspan icon indicating copy to clipboard operation
kspan copied to clipboard

Check gofmt on PRs

Open bboreham opened this issue 4 years ago • 2 comments

Evidently golangci-lint isn't doing it, as seen at #19

bboreham avatar Apr 08 '21 17:04 bboreham

I am interested in contributing to this project. I think this issue is fixed. Looking at the #64

Run golangci/golangci-lint-action@v2
prepare environment
go env
Installed Go in 68ms
Requested golangci-lint 'latest', using 'v1.41.1', calculation took 94ms
Installing golangci-lint v1.41.1...
Downloading https://github.com/golangci/golangci-lint/releases/download/v1.41.1/golangci-lint-1.41.1-linux-amd64.tar.gz ...
Cache not found for input keys: golangci-lint.cache-2691-23dfab94cf6e959b68510ed62773e31da4864cf2, golangci-lint.cache-2691-, golangci-lint.cache-
/usr/bin/tar xz --overwrite --warning=no-unknown-keyword -C /home/runner -f /home/runner/work/_temp/8a2b2ae7-8d14-4b74-b4e0-9151d3df5732
Installed golangci-lint into /home/runner/golangci-lint-1.41.1-linux-amd64/golangci-lint in 481ms
Prepared env in 577ms

run golangci-lint
  Running [/home/runner/golangci-lint-1.41.1-linux-amd64/golangci-lint run --out-format=github-actions --timeout=5m] in [] ...
  golangci-lint found no issues
  Ran golangci-lint in 73097ms

ksudhir007 avatar Sep 10 '21 08:09 ksudhir007

I don’t see what you mean at #64. What happens if you make a PR which does not have the correct formatting?

bboreham avatar Sep 10 '21 12:09 bboreham