lein-ring icon indicating copy to clipboard operation
lein-ring copied to clipboard

Make skip-file? optional/configurable

Open alexanderdean opened this issue 11 years ago • 8 comments

Would it be possible to make war/skip-file? configurable or optional?

The reason I ask is that currently uberwar skips files/folders beginning with ., which doesn't play nicely with Amazon Beanstalk (which uses an .ebextensions directory, see http://aws.typepad.com/aws/2012/10/customize-elastic-beanstalk-using-configuration-files.html for details).

/cc @yalisassoon

alexanderdean avatar Nov 26 '12 13:11 alexanderdean

This would be really useful. How do folks who use lein beanstalk customize their beanstalk config with this limitation? Is there some other mechanism besides .ebextensions?

aiba avatar Jul 10 '13 12:07 aiba

@aiba - for a workaround see: https://github.com/snowplow/snowplow/blob/master/2-collectors/clojure-collector/tasks/leiningen/aws.clj

alexanderdean avatar Jul 10 '13 12:07 alexanderdean

@alexanderdean thanks for the tip. I have a beanstalk project and I like using lein-beanstalk to deploy. How do I incorporate your robert.hooke fix in my current project. Thanks :)

timewarrior avatar Jul 13 '13 04:07 timewarrior

@alexanderdean figured it out. created a task mybeanstalk which calls the other beanstalk after applying the hook. Thanks for doing most of the research :)

timewarrior avatar Jul 13 '13 04:07 timewarrior

@alexanderdean thanks, I did as @timewarrior did and created my own task which calls the lein-beanstalk task after applying the hook.

aiba avatar Jul 17 '13 07:07 aiba

This would be very helpful.

Actually, it might be sufficient if :filespecs (see #78) could override skip-file?.

wiseman avatar Feb 21 '14 03:02 wiseman

I've packaged Mark Butler's workaround for this issue as a standalone lein plugin: lein-awsuberwar

wiseman avatar Feb 26 '14 20:02 wiseman

What about adding an :uberwar-inclusions key, analogous to the keys for jars/uberjars? I see in the lein sample file that it even demonstrates this use for Elastic Beanstalk:

:jar-inclusions [#"^\.ebextensions"]

though lein ring uberwar doesn't seem to look at any of the existing -inclusions keys.

kengruven avatar Mar 28 '18 01:03 kengruven