hiccup icon indicating copy to clipboard operation
hiccup copied to clipboard

Clojerl support

Open metehan opened this issue 3 years ago • 4 comments

metehan avatar May 12 '21 00:05 metehan

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message subject is over 50 characters.

atomist[bot] avatar May 12 '21 00:05 atomist[bot]

Many of the conditional expressions have repetition that could be removed. The tests will also need to be fixed, and the CI needs to include tests for Clojerl as well.

weavejester avatar May 12 '21 00:05 weavejester

Ops everything failed. @weavejester could you make an initial check if it's generally ok I can make a cleaner PR. @jfacorro have changed file names to follow https://github.com/clojure/clojurescript/wiki/Using-cljc convention. I guess you wouldn't want some filename changes right?

metehan avatar May 12 '21 00:05 metehan

Using cljc files is fine. The code looks generally okay.

weavejester avatar May 12 '21 01:05 weavejester