decorate icon indicating copy to clipboard operation
decorate copied to clipboard

Published 20 hours ago • verified publisher icon weavejester

Docstring typo or oversight.

Open danielsz opened this issue 10 years ago • 4 comments

Hello James,

I think you didn't mean value in the docstring of redef. You're redefining a var.

I was studying these macros for educational purposes. PRs like these may be a bit pedantic. Sorry for that.

Lovely library BTW.

danielsz avatar Oct 30 '15 08:10 danielsz

This library should be considered deprecated. I'll add a note to the README.

weavejester avatar Oct 30 '15 14:10 weavejester

OK.

Out of curiosity, is there an issue with the macros as such? Do you advise against their usage? And if so, how would you decorate functions today?

danielsz avatar Oct 30 '15 14:10 danielsz

Yes, I advise against using this library. Creating a new var instead of redefining an existing one should be considered the more idiomatic approach.

weavejester avatar Oct 30 '15 15:10 weavejester

Thanks. :+1:

danielsz avatar Oct 30 '15 17:10 danielsz