James Reeves

Results 771 comments of James Reeves

That's a good idea, and I've already implemented it :wink: . The [ring.websocket](https://github.com/ring-clojure/ring/blob/master/ring-core/src/ring/websocket.clj#L8) namespace extends the `Listener` protocol to cover a map of functions.

That would be fine as two optional settings.

I'm fine with this, and it adheres to the Clojure Style Guide. However, I won't have a lot of time to spare to spend on this; I'll review and merge...

No, this hasn't been implemented. I'll reopen the issue.

Thanks for the PR, and my apologies for not being clear about the design I was suggesting. In clojure.test and other similar libraries, the reporting function reacts to events like...

Apologies for the delay in looking at this. I'll review the code now.

To give a little more context, this was the design I had in mind for the CLI reporter. Note that the method signature remains consistent: `event context data -> context`,...

Thanks for your work on this. It all looks good. Can you squash your commits down and give it an appropriate commit message?

Thanks! Could you change the commit message to: ``` Add :report option to check and fix Allows for a custom reporter function when checking/fixing files. ``` I think that's perhaps...

Thanks for the fix, and sorry for the delay again. It's been a busy week! It all looks good if you want to squash the changes.