traduttore icon indicating copy to clipboard operation
traduttore copied to clipboard

[WIP] Add basic support for SourceForge

Open swissspidy opened this issue 5 years ago • 4 comments

Because we can 🤷‍♀️

SourceForge supports Git, Mercurial, and Subversion. All at once or none at all. That means people will still need to hook into traduttore.loader to choose the correct source code loader.

swissspidy avatar Oct 30 '18 19:10 swissspidy

Codecov Report

Merging #77 into master will increase coverage by 0.42%. The diff coverage is 87.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     78.05%   78.47%   +0.42%     
- Complexity      333      347      +14     
============================================
  Files            23       24       +1     
  Lines           802      841      +39     
============================================
+ Hits            626      660      +34     
- Misses          176      181       +5
Impacted Files Coverage Δ Complexity Δ
inc/LoaderFactory.php 100% <ø> (ø) 4 <0> (ø) :arrow_down:
inc/WebhookHandlerFactory.php 100% <100%> (ø) 6 <0> (+1) :arrow_up:
inc/WebhookHandler/Base.php 100% <100%> (ø) 12 <0> (+2) :arrow_up:
inc/RepositoryFactory.php 87.09% <20%> (-12.91%) 14 <0> (+2)
inc/WebhookHandler/SourceForge.php 96.55% <96.55%> (ø) 9 <9> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a580c45...417d321. Read the comment docs.

codecov-io avatar Oct 30 '18 19:10 codecov-io

Is there a reason why this is not failing the tests?

Which ones should fail in your opinion? I didn't add any loader tests for this one (because of the manual involvement) and existing ones shouldn't be affected. Plus, existing loader tests are currently skipped anyway.

swissspidy avatar Nov 02 '18 13:11 swissspidy

I didn't add any loader tests for this one (because of the manual involvement)

Ok, that makes sense now.

grappler avatar Nov 02 '18 13:11 grappler

Do you have a repo that we can use to test that it is working?

I've set up https://sourceforge.net/projects/pascals-test-project/ but with no webhooks configured yet. It's on my todo list :-)

I also have two GitLab repositories that I still want to properly test for #61.

swissspidy avatar Nov 05 '18 08:11 swissspidy