lint-action icon indicating copy to clipboard operation
lint-action copied to clipboard

add clippy support

Open Krenodeno opened this issue 4 years ago • 4 comments

Hi,

I tried to add Clippy support.

I don't know what lint can display, I just used other lints as examples to make this one.

  • [x] Clone the repository and install its dependencies with yarn install.
  • [x] Create a new class for the linter, e.g. src/linters/my-linter.js. Have a look at the other files in that directory to see what functions the class needs to implement.
  • [x] Import your class in the src/linters/index.js file.
  • [x] Provide a sample project for the linter under test/linters/projects/my-linter/. It should be simple and contain a few linting errors which your tests will detect.
  • [x] Provide the expected linting output for your sample project in a test/linters/params/my-linter.js file. Import this file in test/linters/linters.test.js. You can run the tests with yarn test.
  • [x] Update the action.yml file with the options provided by the new linter.
  • [ ] Mention your linter in the README.md file.
  • [ ] Update the test workflow file.

Krenodeno avatar Jun 26 '20 10:06 Krenodeno

Not sure how to fix Windows tests, ${dir} translate as a path like this one :

D:\a\lint-action\lint-action\test\tmp\clippy/src/main.rs

And clippy output the path like this :

D:\\a\\lint-action\\lint-action\\test\\tmp\\clippy\\src\\main.rs

Krenodeno avatar Jun 26 '20 16:06 Krenodeno

Thank you for your contribution to this project!

A stale label has been added to this pull request because it has been open 45 days with no activity. To keep this PR open, add a comment or push a commit within 10 days.

github-actions[bot] avatar May 27 '21 03:05 github-actions[bot]

I will try to fix the windows behavior in the next days

Krenodeno avatar Jun 01 '21 10:06 Krenodeno

Thank you for your contribution to this project!

A stale label has been added to this pull request because it has been open 45 days with no activity. To keep this PR open, add a comment or push a commit within 10 days.

github-actions[bot] avatar Aug 16 '21 02:08 github-actions[bot]

Can be closed as #586 got merged and fixed what I left unfixed, thanks @nick-mobilecoin !

Krenodeno avatar Jan 30 '23 12:01 Krenodeno