Waldek Maleska

I like the proposal for approval rules syntax, it's concise and logical. It does sound much more convenient to use group/user/branch names instead of IDs, I've not used the IDs...

We've been doing some Gitlab housekeeping and reorg within my team and as it turned out, we are now very interested in having the feature of multiple approval rules (and...

For what it's worth, I've used python-gitlab for a few minor tasks and it usually does the job well. Maintainers do a great job. Once or twice it did go...

The only other part of syntax I find slightly unclear and potentially to be considered while bumping the major version is the configuration of groups. Currently there are `group_settings` which...

For your information (and for the record): for now I've worked around that with Jinja2 templates. It's not quite ideal, however using [vault-cli](https://github.com/peopledoc/vault-cli) helped me to very easily fill in...

Yes, an ability to grab values from environment or to pass arbitrary Jinja variables on via CLI to gitlabform (e. g. `-e foo=bar -e baz=qux`) and so on would be...

> It needs a build time label/property to be set/passed. This is not always possible if you have multiple CI systems or process pushing images That's what it says on...

if "latest" tag in active use, implementation of https://github.com/jfrog/artifactory-user-plugins/issues/333 would IMO mitigate this problem.

## Tests for maxDays option ### Tests data (input) ``` docker-test/test/v1/manifest.json creat=2022-01-17T10:08:28.118Z modified=2022-01-17T10:10:17.194Z maxDays=1 docker-test/test/v2/manifest.json creat=2022-01-17T10:12:18.444Z modified=2022-01-17T10:12:18.439Z maxDays=1 docker-test/test/v3/manifest.json creat=2022-01-17T10:14:19.751Z modified=2022-01-17T10:14:19.747Z maxDays=1 docker-test/test/v4/manifest.json creat=2022-01-17T10:16:21.080Z modified=2022-01-17T10:16:21.075Z maxDays=1 docker-test/test/v5/manifest.json creat=2022-01-17T10:18:22.315Z modified=2022-01-17T10:18:22.311Z maxDays=1...

I have read the CLA Document and I hereby sign the CLA