wepos icon indicating copy to clipboard operation
wepos copied to clipboard

Feature: progress bar

Open PieturP opened this issue 3 years ago • 1 comments

Disable the 'Scan' button until all products are fetched. Show progress bar while loading.

PieturP avatar Aug 03 '21 09:08 PieturP

Hello @PieturP, While testing your PR, We have noticed few points that need to be addressed:

  • You have implemented a progress bar on top of the product searching section, which in my opinion is not necessary as we already have a loading state and animation on the products section. From a UX perspective, having multiple loading progress for a single screen arises confusion for the users.
  • Current PR has an issue with product searching. If you search for a product in the search bar, no products are shown in the search dropdown.

Feedback:

  • You can use the current loading state and animation. Maybe use some CSS styling for toggling the disabled state for the 'Scan' button.
  • Look into the product searching issue.

I will be glad to help if you have any questions further.

xaviranik avatar Aug 06 '21 15:08 xaviranik