wdfk-prog
[LoRaMac]Optimize code reading and execution conditions and Add functions for use by the outer layer
> Hello @wdfk-prog, > > Please can you give some details about your pull request. > > Regards, As I read through the code, I noticed that it could be...
[LoRaMac]Optimize code reading and execution conditions and Add functions for use by the outer layer
> Hello, > > I forwarded your proposal to development team. > > Regards, I have updated some code, please check it out
Thanks for explaining. I have no more questions.
> https://github.com/RT-Thread/rt-thread/blob/fe1308976ee6268d50890b4df7adecb182e309e5/bsp/stm32/libraries/HAL_Drivers/drivers/drv_can.c#L707 - sce中断有定义且有做处理 - 请排查一下是否进入该中断,进入后的具体中断标志是什么触发的.中断处理程序有没有执行错误处理
> > > [rt-thread/bsp/stm32/libraries/HAL_Drivers/drivers/drv_can.c](https://github.com/RT-Thread/rt-thread/blob/fe1308976ee6268d50890b4df7adecb182e309e5/bsp/stm32/libraries/HAL_Drivers/drivers/drv_can.c#L707) > > > ``` > > > Line 707 > > > in > > > [fe13089](/RT-Thread/rt-thread/commit/fe1308976ee6268d50890b4df7adecb182e309e5) > > > > > > > > >...
https://github.com/terjeio/Trinamic-library/blob/d261eb7393126f0aeb02114c5cc881c7e78728d4/tmc5160.c#L151 - TMC5160Reg_ENCM_CTRL No definition found
https://github.com/RT-Thread/rt-thread/blob/af2c8ae1745f2231f04f94b65d4c41bee6b393c7/bsp/stm32/libraries/HAL_Drivers/drivers/drv_hard_i2c.c#L128-L134 - 这里不就是吗 - ?
> > [rt-thread/bsp/stm32/libraries/HAL_Drivers/drivers/drv_hard_i2c.c](https://github.com/RT-Thread/rt-thread/blob/af2c8ae1745f2231f04f94b65d4c41bee6b393c7/bsp/stm32/libraries/HAL_Drivers/drivers/drv_hard_i2c.c#L128-L134) > > Lines 128 to 134 in [af2c8ae](/RT-Thread/rt-thread/commit/af2c8ae1745f2231f04f94b65d4c41bee6b393c7) > > static rt_err_t stm32_i2c_configure(struct rt_i2c_bus_device *bus) > > { > > RT_ASSERT(RT_NULL != bus); > > struct stm32_i2c...
- readme可以增加一下风险提示,高64kb或许不够可靠
> > 请将提交信息通过rebase压缩成一个commit > > 这个是从修改nano开始压缩吗 - 这个pr的多个commit整合成一个commit就好了. - 这个pr没必要多个commit提交