nova-calendar
nova-calendar copied to clipboard
wdelfuego
Week view added
- added week view to Nova Calendar
- views can be enabled in nova-calendar.php config file, selector buttons are located in top right area
- direct links from month view to selected week enabled
- README updated
Modified standard behaviour to render only month view, if no calendarView key provided in config file. If it's empty array, calendarView method in AbstractCalendarDataProvider class returns only ['month'] array. As consequence sanitizeCalendarViews method in CalendarController class simplified.
Cool, thanks :)
the same goes for the week numbers, by the way. Updating to this new release should change nothing about the calendar, only make the new features available to the developer, not the end user.
As an open source project I'd prefer to discuss the merge publicly on GitHub, so that other users can chime in and read what the considerations are / were. Is that ok for you?
Also, let me know if you'd like to be mentioned as a copyright holder in the readme and on-line docs.
You're the first contributor that has made such a big feature 🙌, really spectacular work! I'm excited about finishing up the release :)
Cheers! Willem
On 5 Jul 2023, at 12:20, Bartosz Bujak @.***> wrote:
Modified standard behaviour to render only month view, if no calendarView key provided in config file. If it's empty array, calendarView method in AbstractCalendarDataProvider class returns only ['month'] array. As consequence sanitizeCalendarViews method in CalendarController class simplified.
— Reply to this email directly, view it on GitHub https://github.com/wdelfuego/nova-calendar/pull/62#issuecomment-1621467527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKDYOGOEBWXBLRYJSFTBTLXOU5WHANCNFSM6AAAAAAZ6C5JTE. You are receiving this because you were assigned.
Hello Team,
week numbers are not displayed by default now. Regarding to:
- communication regarding to PR here - I'm absolutely fine,
- copyrights - yes please, kind, thanks!
Thanks for warm words and patience. I'm keen on to work on next steps, daily and timeline views.
Bartosz
Just a small heads-up that I've been extensively reviewing the pull request and - great work, Bartosz!
I'm compiling a list of things to fix / improve before releasing the feature and have begun implementing a couple of them myself. I'll post the list and an update here later this week or next week at the latest.
Thank you for reviewing as well as code refactoring and simplifying in some cases. Before I start to update this PR I'd like to agree some issues.
Layout
You are right, naming of variables addresses my context needs, so it should be more self-explaning to all developers,
- The openingHour/ closingHour variable addresses me needs not to show events which are out of the standard working hours (business working hours); my intention was, to give developer ability to show events, which are out (before and later) but as minimal as it can be (see pic 1); especially in appointments scheduling cases there is no need to show hours which are out of business, on the other hand - not showing events which are booked during night hours can bee missleading.
- The second intention was to visualise which hours (timeslots) are working and which not.
We can handle this in two ways to address use case described above:
- leave it as it is (with correcting variable naming convetion of course);
- refactor it to render all hours (00:00 - 23:59) but to scroll the component to the earliest event during the week - in this approach marking working hours would be still needed, I'm afraid of scrolling view programatically because of web view size and compatibility issues I experienced.
I'm leaving this as a point for discussion. I wonder your opinion on this.
Things to be changed prior final release of week view
- Flickering views changing - it's obvious, I wonder how I missed this.
- Uniform header view - good idea.
- Week view leftovers in local storage - sure.
Style changes
- View selector (active) - sure
- Left dashed border instead of top dashed in all days events - of course, it's a bug left by myself
- Month names on week view - agree
- Multiple events starting the same time - I agree that UX of such display is not great, I've thought about overlaping events with transparency (like in macOS Calendar App) but have no idea how to do this with CSS only, on the other hand extending time slot and make it not proportional timescale is not what I prefer. MS Teams app for macOS presents events in this way and readability of this is challenging. I think it's the compromise between CSS flexibility and probability of materialising case when more than 2 or 3 events would start the same hour. I'm focused on appointments scheduling use case, when such cases occurs seldom. I thought also about popup view on hover to show more details of event if mouse is over it.
- I'll noticed that second calendar view label is not capitalised despite of proper CSS attributes (despite if pure CSS styling or Tailwind used).
Summarising:
@wdelfuego If we can split work on it in the way you proposed - it would be great. Only one disadvantage is that I can work on calendar views Vue components about last week of Aug / first week of Sep.
Thanks again, regards!
Hey @bb140856, thanks for your response!
W.r.t. the openingHours/closingHours, I am all for leaving it as is, just a change of variable naming because those are 'interpreted' names, I just want a more neutral name. I'm not fond of showing all hours and auto scrolling to the first event either.
In the month view, the calendar shows 6 full weeks but we're only really actively viewing the current month. That is analogus to seeing the full 24 hours but only really actively viewing some time range (eg 8am - 5pm), so perhaps we can use analogous naming, too. In the Month view there are 6 full weeks between startOfCalendar and endOfCalendar, but only 28-31 days between startOfRange and endOfRange. Translated to Week view that could be the full 24h range = startOfDay to endOfDay and the configurable 'office hours' thing could be rangeStartHour to rangeEndHour, something like that. I
What I don't understand yet is why in src/View/Week.php there is a const LAYOUT that holds openingHour, closingHour and timelineInterval, and then there's the $openingHour, $closingHour and $timelineInterval private properties. How do these relate to each other? Are they both required? This is not clear to me from the code.
W.r.t. showing events that overlap horizontally next to each other, I would very much prefer a different solution. I wouldn't mind growing timeslots, since that is what happens in the month view, too, and while I understand that it doesn't feel maximally elegant, I think it's very preferable to not being able to see any event info at all.
W.r.t. "Week view leftovers in local storage"; I would prefer the back-end to be able to respond to a request for week data with month data + a variable indicating that the front-end should switch to month view. That way the back-end decides the state of the calendar after a request, just as is currently the case with other 'dynamic' properties of the calendar view (year/month/filters).
I'm all for splitting the work, that's great :)! I'm very busy so I'll wait for your Vue component update around the end of August / beginning of September to get rid of flickering component changing and to make the calendar toolbar a fixed part of the main view, and I'll pick it up from there to get this to release, hopefully somewhere in September.
Thanks @bb140856, a pleasure working with you 😃
Thanks a lot for working on this @bb140856 and @wdelfuego ! I'm really looking forward to this addition as my client has been asking for a week view for a long time now!
Yeah, I'm also highly anticipating the release of this feature myself :).
Your client is free to sponsor some development of the feature if they want!
Yeah, I'm also highly anticipating the release of this feature myself :).
Your client is free to sponsor some development of the feature if they want!
Not that kind of client I'm afraid.. I've never seen a dime from them and they're barely staying afloat themselves. I do dev work for them (Ski Shop) and they give me some free snowboard rentals and the occasional free instructor lesson. If you're ever in Bansko, Bulgaria, I'm pretty sure I can get you some free rentals too after I explain who you are ;-)
Haha, I'll keep that in mind ⛷ ;)!
The feature will come, it's just we both have little time, but it will definitely come!
Hi @mauveine , thanks for reaching out!
The points I mentioned in this comment still need adressing. This is a couple of days work at the most but I have unfortunately not been able to make time for it yet.
You could help by 1) making the pull request up to date with the latest changes to the main branch and 2) addressing one or more of the issues mentioned in that comment.
Another way to go forward with this is if someone or some company would be willing to sponsor development time on it to make things go faster.
It looks that this PR is blocked. What do you need ($) to finish to merge it?
I'd prefer to discuss money matters in private, but I think I'll be able to resolve all outstanding issues and release a week view feature with four or five days of development. You can take a look at the sponsoring page or get in touch with me at willem AT studiodelfuego DOT com for more info.