Will Dean

@ricardoV94 Does the join kwarg address this?

The lift tests will need something like [this:](https://github.com/wd60622/pymc-marketing/blob/2be2f639b0cddcdc66a79a77709c7bfb1d98321d/pymc_marketing/mmm/lift_test.py#L371C1-L386C) ```python variable_mapping = { "lam": "saturation_lambda", "beta": "saturation_beta", } def saturation_function(x, beta, lam): return beta * logistic_saturation(x, lam) add_lift_measurements_to_likelihood( df_lift_test, variable_mapping, saturation_function=saturation_function,...

> I have still the issue of: > > ```python > Traceback (most recent call last): > File "/home/docs/checkouts/readthedocs.org/user_builds/pymc-marketing/envs/632/lib/python3.10/site-packages/sphinx/config.py", line 358, in eval_config_file > exec(code, namespace) # NoQA: S102 >...

Action items: - [x] Run the notebooks @cetagostini - [ ] Point out new functionality in notebook @cetagostini - [ ] Add docstring example for defining a custom saturation function...

Lots of good stuff here. Think we got some more items to tackle Sadly, I think the name change should be separate from this PR. Though having flexible saturation and...

I will make some tests and add to docs after the weekend!

FYI: https://github.com/cetagostini-wise/pymc-marketing/pull/3

I've added some docstrings https://github.com/cetagostini-wise/pymc-marketing/pull/4

I think that this will close this issue: #383 Someone else might know a bit more context about that

> I've added some docstrings > > https://github.com/cetagostini-wise/pymc-marketing/pull/4 Able to merge these in @cetagostini ? Think we are gettig closer. Any items you need help with?