Will Constable comments

Results 125 comments of


                                            Will Constable

[c10d] Fix _set_pg_timeout not working for Gloo backend

@d4l3k can you take a look? @RohitRathore1 would you be able to add a test? we might have a test in `test_c10d_nccl` that you could copy/modify for gloo.

[c10d] Fix _set_pg_timeout not working for Gloo backend

I don't think you need my approval, @d4l3ks should be enough! But you might need @sladyn98 to remove the 'request changes' and accept.

[DTensor] Fix torch.equal with scalar DTensor inputs

Might be be worth merging this as is and make a separate PR with the global fix.

[DTensor] Fix torch.equal with scalar DTensor inputs

@mansiag05 are you able to figure out the CI failures?

[dtensor][partial] redistributes _NormPartial to replicate for necessary pointwise_ops

i guess this CI failure is unrelated, but you should rebase to make sure. > ____________________ InplacePaddingTest.test_linear_and_cel ____________________ Traceback (most recent call last): File "/var/lib/jenkins/workspace/test/inductor/test_inplace_padding.py", line 247, in test_linear_and_cel self.assertEqual(num_inplace_padding(),...