yalc icon indicating copy to clipboard operation
yalc copied to clipboard

feat: add a yalc-using package

Open aleclarson opened this issue 6 years ago • 4 comments

During yalc publish, the local .yalc directory is now copied to the global store, but its files are excluded from the content hash. Finally, the local yalc.lock file is copied and hashed.

The relevant commit: a9263e0caf2da69ec95a14e2ceba431315f7b498

(Probably wanta merge #66 first)

aleclarson avatar Jan 02 '19 20:01 aleclarson

Note: If you used yalc link in a package, the published version of that package will not use the linked package, because yalc link doesn't affect the package.json file.

aleclarson avatar Jan 11 '19 21:01 aleclarson

We need to consider if yalc push should be cascading or not. For example, if I do yalc push and it updates another yalc-using package, should that package be pushed as well? I'd say we probably want to prompt the user for them to decide. 😄

aleclarson avatar Jan 16 '19 15:01 aleclarson

TODO: Skip copying .yalc/{name} directories that correspond to devDependencies.

aleclarson avatar Jan 20 '19 21:01 aleclarson

Another thing to consider:

Since node.js doesn't dedupe packages based on version, there's a good chance of having multiple "instances" of the same package when yalc is used extensively in a dependency tree. This can easily lead to confusing bugs.

We could prevent duplicate yalc-linked packages by hoisting them or by linking to the same .yalc directory for every yalc-using package; neither of which sounds particularly easy.

aleclarson avatar Jan 30 '19 01:01 aleclarson