r-debug icon indicating copy to clipboard operation
r-debug copied to clipboard

New binary for noLD?

Open MichaelChirico opened this issue 6 years ago • 4 comments

First thanks so much for this image. Has proved quite valuable for package dev already on multiple projects.

The last check that's missing (IINM?) is to be able to run tests of a package on a machine without long double support (build option --disable-long-double). rhub has a way to do this but being able to log into an image and do things more interactively is more convenient.

Or if you have a different way that you're doing noLD checks of your packages, would love to hear it.

MichaelChirico avatar Sep 13 '19 10:09 MichaelChirico

I've never encountered noLD issues before. I'm a little reluctant to add another build of R to this image since it's already quite bloated, and the --disable-long-double setting is slightly different from the memory-related builds of R that are in this docker image. But if noLD really is the only other build that is relevant then I could be convinced.

@gaborcsardi Do you think that there are potentially any other builds of R that one might want to add for debugging other issues? If so, then maybe we should create another docker image for them; if not, then maybe we can add noLD to this one.

wch avatar Sep 13 '19 15:09 wch

R-hub already has a noLD builder. The image is here: https://github.com/r-hub/rhub-linux-builders/tree/master/debian-gcc-devel-nold https://cloud.docker.com/u/rhub/repository/docker/rhub/debian-gcc-devel-nold

gaborcsardi avatar Sep 13 '19 15:09 gaborcsardi

thanks for the image @gaborcsardi! I had seen rhub can be used to run tests with noLD but didn't have luck getting to the image before.

understood & basically agree re: weight of image with all the binaries on there.

one could imagine an image with all of the CRAN checks being quite useful:

https://cran.r-project.org/web/checks/check_issue_kinds.html

As a way to do everything interactively without having to log in/back out / spin up new docker containers... but that list is a bit long in fact. Even collapsing all of the {gcc,clang}-{san,ubsan} versions into just one there'd be 9 binaries. Personally I haven't seen any BLAS-related issues which would remove 3 more, but we did just see an LTO issue and often hit things with rchk.

What might make more sense is to split this image to cover different CRAN checks by tag, e.g.

wch1/r-debug:noLD
wch1/r-debug:valgrind
...

which would at least feel completely centralized to one place...

MichaelChirico avatar Sep 13 '19 17:09 MichaelChirico

Just some thoughts... I'm content enough having the image Gabor mentioned that this could be closed as you see fit from now.

MichaelChirico avatar Sep 13 '19 17:09 MichaelChirico