harbor
harbor copied to clipboard
wch
CRAN bound?
@wch any plans to send this to CRAN? I was thinking of getting analogsea to CRAN soon. We don't use harbor yet, but we could more easily if on CRAN
No plans to anytime soon... If you want to clean it up, please feel free to do so. :)
On Fri, Aug 7, 2015 at 2:54 PM, Scott Chamberlain [email protected] wrote:
@wch https://github.com/wch any plans to send this to CRAN? I was thinking of getting analogsea to CRAN soon. We don't use harbor yet, but we could more easily if on CRAN
— Reply to this email directly or view it on GitHub https://github.com/wch/harbor/issues/5.
ok, I'm just getting back into analogsea work, so I'll go over the harbor related stuff soon
If it just needs updates to the documentation so it passes CRAN checks, I can help with that - it now passes a CRAN check in this pull https://github.com/wch/harbor/pull/7, probably a bit more to do
Piling on here to see how I might help get this into CRAN and to suggest that it doesn't need to support boot2docker anymore with Docker being a first class citizen on macOS & Windows now. I freely admit this is selfish since I'm using it in https://github.com/hrbrmstr/splashr to install, start & stop a Splash server, but in doing so realized that this could be an excellent model for other middleware engines (like Splash, Selenium, phantomjs, etc) to keep those things separate from the local operating system and abstract the complexity away from R users.
So, I'm here to help and willing to mod/clean, but don't want to stop over any other work in the other two forks, so just lemme know what I can do to help get this puppy in CRAN.
I can also just ask permission to copy-and-credit-at-will from it to make splashr work, but this would be a wicked useful pkg in the wild IMO.
I did the copy-and-credit-at-will approach for my CRAN submission, maybe added an extra function or two but would prefer pulling that out into this package on CRAN
I don't plan on spending time on harbor in the foreseeable future, so if you guys want to become admins on the project and do the release/maintenance, let me know.
@hrbrmstr Done. Before you release, please feel free to make yourself the maintainer (AKA cre) in the DESCRIPTION file.
Cool. @sckott @MarkEdmondson1234 I'm prbly going to be pushing "breaking" changes soon (next 24-48 hours). I'm switching to sys and adding some more general Docker mgmt commands. It may not impact anything y'all are doing but wanted to make sure you both knew that. There are a handful of folks watching and Rich has a somewhat active fork, so hopefully anyone else "depending" on this will see what's going on.
A big change is removing "boot2docker" support since Linux, Windows and macOS all work the same way now. Unless there's a YUGE objection to that.
sounds good - was going to move to using this in analogsea - but never got around to this, so happy someone is doing it
Any updates to sending this onto CRAN? It would work nicely I think with my little wrapper to docker-machine (https://github.com/cboettig/dockermachine) to allow R users to script deploys of long-running jobs to the cloud without having to leave the R interface
I'd need to give it a few more test on Travis, but Appveyor can't do docker-ish test (in any good/real way) yet. Neither can r-hub. Are there some Windows folks who can give it a spin (or who have given it a spin)?
Alternatively, an initial CRAN submission w/Linux & macOS as the two (out
of three) major platforms would also work, especially if the current
harbor API seems to be usable/logical.
TLDR: I wld not mind putting the finishing touches on it for a CRAN sub if it's working for folks or just needs minor tweaks for folks.
On Tue, Sep 5, 2017 at 12:23 PM, Scott Chamberlain <[email protected]
wrote:
dont know, thoughts @hrbrmstr https://github.com/hrbrmstr ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wch/harbor/issues/5#issuecomment-327228943, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfHtmwTbkNZXlCMKsmqj1ZtORgRqfrJks5sfXWCgaJpZM4FnyMP .
:+1: on initial submission for Linux/macOS, though if Windows tests are a blocker, I'd get my hands on a Windows 10 machine and run tests.
The latest Appveyor has Docker support and I was able to let harbor tests run:
https://ci.appveyor.com/project/nuest/harbor/build/1.0.3
The tests all run, see "artifacts" > file harbor.Rcheck\tests\testthat.Rout:
> library(testthat)
> library(harbor)
>
> test_check("harbor")
== testthat results ===========================================================
OK: 3 SKIPPED: 0 FAILED: 0
>
I was also able to fix warnings and tests complete for different R versions:
https://ci.appveyor.com/project/nuest/harbor/build/1.0.5
So basic features work on Windows and can be tested on Appveyor with these changes: https://github.com/wch/harbor/compare/master...nuest:appveyor?expand=1
I'd be happy to contribute some more tests following the todo list by @hrbrmstr and create a PR.
- [ ] Before CRAN, the status badges should be updated to the main repo.
Oh this is gd news (apologies for the late reply). Have folks seen https://github.com/richfitz/stevedore ? It does the docker API vs cmdline machinations but is pure R vs an R shim to Python.
I did not know stevedore, thanks for the pointer. The approach using the API+Swagger is quite cool. AFAICS stevedore is pure R, but the required package httppipe needs reticulate, at least currently, for Windows support.
@hrbrmstr Do you suggest evaluating the different approaches of existing packages before going ahead with submitting harbor to CRAN?