extrafont icon indicating copy to clipboard operation
extrafont copied to clipboard

Easy speed-up possible?

Open sergiocorreia opened this issue 1 year ago • 1 comments

Hi Winston,

When running font_import() I get the message "Importing fonts may take a few minutes" and it indeed takes quite a while even if all fonts are already registered.

It seems this is because we are essentially running an O^2 task as every time we try to add a new font we re-run fonttable(), which reloads the underlying CSV file entirely.

Would it be easier to do something like fonts <- fonttable() right before we start the loop on line 78?

Thanks!

PS: Sorry for the lack of PRs; I'm quite new using R, so not entirely sure what I'm doing in that sense

sergiocorreia avatar May 19 '23 20:05 sergiocorreia