Winston Chang
Winston Chang
Can you supply a reproducible example? When I run this, the width gets set correctly: ``` > infoBox("a", "b", width=1) a b ``` It looks like you might be using...
Be sure to take a look at https://github.com/rstudio/shinydashboard/blob/2522242f/srcjs/AdminLTE/README-shiny-mods.md. I'm not really sure why there's a copy of app.js in that directory. Now that I think of it, that README should...
Yes, the reason is that there's no space for both the dropdown arrow and the badge. I'll look into the possibility of adding the badge to menuSubItems.
Can you provide a reproducible example?
Interesting -- if I add this to the inside of `f.default`, then `e` does get GC'd. ```R rm(., envir = .GenericCallEnv) ``` Or you can run this outside of the...
Oh, duh, that makes sense. I just didn't have any identifying information in `e` that made it easy to see that `.` and `e` were the same object.
Here's a summary of how chromote uses a private event loop. I think you should be able to adapt it for crrri. * On initialization, a private loop is created....
Have you tested the performance of the old vs new code? Note that the tests will also need to include rendering it to HTML text.
Quick benchmark: ```R system.time({ for (i in 1:5000) { as.character(fa("calendar")) } }) ``` Result before: ``` user system elapsed 0.493 0.023 0.515 ``` After: ``` user system elapsed 4.900 0.030...
Following up on this PR, I think we should merge this only if we have a compelling use case in mind for the tags object over string. It's not too...