Winston Chang
Winston Chang
Sure, better tests wouldn't hurt. We should also have tests for the most common case, which is when the args are missing.
I think it would be good if we could get rid of the interrupt. However, there may be some problems with doing it via an `onSessionEnded` callback. We don't want...
After a brief discussion with @kevinushey it looks like RStudio might be able to call `stopApp()` when the window is closed, instead of sending an interrupt to the R process....
I think it would actually be more consistent with the rest of Shiny to _not_ suspend interrupts when executing the session-end callbacks. All other app code in a Shiny app...
I think it would be best to just close this PR -- if another use case comes up, then we can come back to it.
I think it would make more sense to just `stop()` if there are more than two values. Also, the check can go closer to the top of the function, before...
Can you provide an example of how the application author would use this?
If I understand the code correctly, wouldn't this also work (without the call to `body()`)? ```R shinyApp( ui = fluidPage( "Page content", tags$template( id = "shiny-disconnected-overlay-template", tags$div("some content") ) ),...
@krlmlr Can you provide instructions on how to reproduce the issue?
@wfjvdham We are switching to a new, automated system for CLA's, which unfortunately requires everyone to agree to the CLA using the online system, even if they have already sent...