pecl-gearman icon indicating copy to clipboard operation
pecl-gearman copied to clipboard

Add support for SSL connections to gearmand (Issue #43)

Open esabol opened this issue 5 years ago • 3 comments

This addresses issue #43. It relies on a version of libgearman.so that supports the setSSL() API, which is not yet part of any gearmand release. Refer to https://github.com/gearman/gearmand/issues/63 for details on that issue. These changes are based on [email protected]'s patch for some old version of PHP. I heavily modified the code to work with PHP 7.x.

These changes probably need #ifdef HAVE_LIBGEARMAN_SETSSL (or something like that) around them in order to support libgearman.so's that have setSSL() and those that do not.

I've never actually tested it with a PHP SSL worker. We only use PHP SSL on the client side here....

esabol avatar Nov 19 '19 21:11 esabol

I'm reluctant to test this if it's not on both server and client side.

I'm several years now out from working directly with either Gearman or PHP, so I'm unable to maintain this going forward. Happy to pass the torch over to another maintainer so it's not held under a personal account of someone who isn't working actively with it

wcgallego avatar Feb 05 '20 11:02 wcgallego

I'm reluctant to test this if it's not on both server and client side.

No part of the support for setSSL() is "server-side". It is part of libgearman.so, which is a library used by Gearman clients and is not used by the gearmand server. I'm assuming you mean "included in a gearmand release". There's a PR for that. It's been reviewed positively, but not yet merged. I'm hopeful that it will be included in the next gearmand release and that a new release is coming soon. That's the plan.

I'm several years now out from working directly with either Gearman or PHP, so I'm unable to maintain this going forward. Happy to pass the torch over to another maintainer so it's not held under a personal account of someone who isn't working actively with it

That's unfortunate, since, AFAIK, this repo is the only working version of this extension for PHP 7+. I hope someone who cares about PHP Gearman will fork and take up the torch. In the meantime, please leave this PR open for others to find.

esabol avatar Feb 07 '20 23:02 esabol

Gearmand 1.1.19 was just released today with support for the setSSL() API!

esabol avatar Feb 11 '20 04:02 esabol