react-native-expo-image-cache
react-native-expo-image-cache copied to clipboard
wcandillon
Support HTTP headers
Adds support for HTTP headers when fetching an image via the headers prop, as you would be able to do with the headers option for the source prop for RN Image.
@VersaLife Thank you so much for contributing this. Should the http headers by passed via the header property of source? This would mean that now the source would be source not URI, which would make it a bit more symetric with <Image> and then it would support this change, do you agree?
ok, let me know, I could take a swing at it too.
On Sun 29 Jul 2018 at 17:33, VersaLife [email protected] wrote:
That would be better yeah, I agree. I'll have a go at making that change
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/wcandillon/react-native-expo-image-cache/pull/79#issuecomment-408685584, or mute the thread https://github.com/notifications/unsubscribe-auth/AASr1gDmFc62ZfQDIO_6uAa8wz6_rZY4ks5uLdWugaJpZM4VPjIW .
That's done - I've just changed the interface of the component and left the CacheManager to deal with the uri and headers only to keep things simple.
@wcandillon can you resolve the conflict and merge this pr, I would like to see this change come through :)
@VersaLife Sorry for taking so much time on this. Could you rebase your PR with the latest version of the module?