packer.nvim icon indicating copy to clipboard operation
packer.nvim copied to clipboard

Don't close Neovim if there's only packer's window

Open mawkler opened this issue 2 years ago • 3 comments

display.close previously closed Neovim if there were no other windows

mawkler avatar May 03 '22 11:05 mawkler

Thanks, and sorry for taking so long to get to this! Do you have an easy reproduction example? I haven't encountered this behavior before.

Separately, though I think it's probably wise to move to api.nvim_win_close regardless, I would feel more comfortable if we stored and used the display window ID rather than relying on the display window being the current window (i.e. by passing 0)

wbthomason avatar Jul 26 '22 07:07 wbthomason

Do you have an easy reproduction example?

  1. Open a Packer window for instance using :PackerStatus
  2. Close all other windows using <C-w><C-o>
  3. Close Packer window by pressing q

mawkler avatar Jul 26 '22 20:07 mawkler

I would feel more comfortable if we stored and used the display window ID

I'm not sure exactly how you want this to be implemented, but feel free to add a commit that fixes this and/or elaborate :)

mawkler avatar Jul 26 '22 20:07 mawkler