Wouter Born
Wouter Born
Hi @ReadThinkBuild! Can you create a PR for this? At the bottom of each page is an "Edit this page" link where you can propose your changes using a PR....
Is there a reason why this is still a draft PR @richturner?
Today it failed again: https://github.com/openremote/openremote/actions/runs/14990468060/job/42112452468 ``` EnergyOptimisationAssetTest > Test storage asset with consumer and producer PASSED Test Test savings calculations FAILED (11.3s) Condition not satisfied after 10.00 seconds and 51...
I already addressed many of your comments. Can you have another look to see if you agree with the changes and check if new issues got introduced?
Yes it only seems to be an issue if you are logged into the master realm and copy/paste URLs of assets in other realms.
I had a look at your branch (`rich/optimisation`) but it currently doesn't seem to build. If you fix the build issues in your branch I can change this PR so...
Now that `rich/optimisation` builds, I've rebased the PR and updated the base branch @richturner.
Spotless can also make sure unused imports are removed and not commited, see https://github.com/openremote/openremote/pull/1441.
Would be nice to get this in now. :slightly_smiling_face:
It would be nicer if it would monitor changes to the file instead (e.g. using the `WatchService`) and then update the cached configuration.