Wouter Born

Results 410 comments of Wouter Born

Still unstable, see: https://github.com/wborn/openhab-core/actions/runs/4217807817/jobs/7328632270 ``` TEST org.openhab.core.thing.internal.ThingManagerOSGiTest#thingManagerConsidersUNKNOWNasReadyToUseAndForwardsCommand()

I've spotted another one: https://ci.openhab.org/job/PR-openHAB-Core/5509/ ``` TEST org.openhab.core.thing.internal.ThingManagerOSGiTest#thingManagerCallsChildHandlerInitializedAndChildHandlerDisposedOnBridgeHandlerCorrectlyEvenIfChildRegistrationTakesTooLong()

Your work got included in https://github.com/openhab/openhab-core/pull/3957 :+1:

This is the exception I ran into today when testing Mockito 5.2.0 with an OSGi based itest in openHAB ([AbstractItemEventSubscriberOSGiTest](https://github.com/openhab/openhab-core/blob/main/itests/org.openhab.core.tests/src/main/java/org/openhab/core/items/events/AbstractItemEventSubscriberOSGiTest.java)): ``` TEST org.openhab.core.items.events.AbstractItemEventSubscriberOSGiTest#testReceiveUnsupportedEvent()

> I need advice how to exclude tool generated Google protobuf classes from checkstyle IIRC we only check our own classes in the `org.openhab` package. So you can move generated...

I had a look and currenty checkstyle is [configured](https://github.com/openhab/static-code-analysis/blob/13982a81c3bbe19a1fec30ed0f9ee440e10cab03/sat-plugin/src/main/resources/configuration/checkstyle.properties#L3) to check everything in `src/main/java`. Some other add-ons have third party sources in [src/3rdparty/java](https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.flicbutton/src/3rdparty) like flicbutton. The build-helper-maven plugin is used...

This PR seems to have been succeeded by #633 which updates the images to bullseye.

It might be an idea to support [Keycloak](https://www.keycloak.org/) and [configure passkeys](https://keycloak.ch/keycloak-tutorials/tutorial-passkey/) in it. Then it becomes very easy to add additional authentication flows (SAML/OAuth2 etc) and also support GitHub/Google etc....

This seems to have already been fixed by https://github.com/openhab/openhab-docs/pull/1144.

I think this issue can be closed when https://github.com/openhab/openhab-docs/issues/999#issuecomment-1336405364 is documented. It should technically be possible to detect the language of the code most of the time and add SAT...