sublime_terminal
sublime_terminal copied to clipboard
wbond
remapped 'open_terminal' command #17
It also makes sense to remap the OS X keys since "super+shift+t" conflicts with the default "keys": ["super+shift+t"], "command": "reopen_last_file"
Terminal existed long before Text Pastry and even before the reopen last file functionality, hence the conflicts.
Sorry for the slow reply on this. We should consider/use the existing thread in https://github.com/wbond/sublime_terminal/issues/17 before making our decision.
@wbond ah, I didn't know the history – but given that that is the state of things now, would you consider a change or this is a nonstarter?
So, 150K people have installed Terminal, and let's say 10% use it regularly. We are talking about breaking a known key binding for 15,000 people for the sake of 1,500 people using Text Pastry, only some of which have Terminal installed?
My initial reaction is that it doesn't make too much sense. That said, there is the reopen last file command that Jon added to Sublime Text itself. That is probably more compelling since it conflicts for every Terminal user.
However, in that situation, Text Pastry should change the keyboard binding also, since it also conflicts with reopen last file.
In the grand scheme of things, key bindings are gonna have issues now that we have 3k+ packages in Package Control. Perhaps everything should ship with a command palette entry and let the user set the key bindings they want?
In the grand scheme of things, key bindings are gonna have issues now that we have 3k+ packages in Package Control. Perhaps everything should ship with a command palette entry and let the user set the key bindings they want?
Very true – conflicts are gonna happen. I don't really feel strongly one way or the other towards letting users set their own key bindings. I don't know how many users actually customize them.
My original comment was merely to point out why the OPs change should apply to OS X as well. Personally, I remapped reopen_last_file to super+shift+t (since that's what Chrome uses for "Reopen Closed Tab" and muscle memory is hard to change), so this isn't going to stop me from using sublime-terminal :smile:
This package should not definitely not conflict with reopen_last_file (and that shortcut similarly reopens a closed tab on Chrome). People can change it back if they want.
I think that the conflict with reopen_last_file should be addressed. Right now I have to add a keybinding to remap reopen_last_file overriding the Terminal keybinding, meaning that you end up with people having to add a keybinding anyways.
A good solution for the people already using the package is adding a message in the new release explaining the change and how to add the key binding back (which is really easy I don't think it'll be a problem). That said, if it was me, I would remove the Keybinding completely from the package (adding the message on the release) to avoid conflicts in the future.
this is a nice project, but it saddens me to see that this has been an issue for so long...
it's a no go to override a frequently used built-in feature short cut that is common across applications like re-opening the last tab.
Please accept this or anything along the lines (e.g., #136) instead of making every mac user delete your defaults...
It would even work to remove the shortcuts completely, as opening the command palette with CMD+SHIFT+P and typing term is pretty damn fast and about as memorable as you can imagine... and in case you want to go to the project folder, it's just the line below...
@theLine Thanks for your PR. The Terminal package is now managed at https://github.com/SublimeText/Terminal, and since 2.0 we've stopped shipping with key bindings completely. Therefore this issue should no longer occur.
